-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infra_role_summary plan #225
Conversation
example output:
|
@MartyEwings can I get your opinion on this? I would also like to add a switch so we return the hash by default, but could switch to a nice table. That will add https://github.com/voxpupuli/puppet-format as a dependency. PEADM does the same in https://github.com/puppetlabs/puppetlabs-peadm/blob/main/plans/status.pp |
@bastelfreak its always good to have a second way of getting the data, crucially this will tell you want it should be, rather than what is, (assuming no one tinkered with the fact), what are you thinking the use case of this data is. With regards adding dependencies for formatting, as this is shipped with PE i cant add 3rd party deps |
I'm working on a plan that writes a bolt config to use peadm::convert. I also could have queried the puppetdb for the pe_status_check_role fact, but that would have been the same effort and I think querying for classes is more secure. Why cant we depend on other modules? PE alreadys ships a lot of modules. |
PE only ships Modules that are authored internally, and even then, i have to get a lot of agreement from product to add anything new. I cant see a formatting module by VOX being approved for packaging and shipping |
meh :( |
@bastelfreak ok, ill do a bit to due diligence on this, but i cant see a reason not to put it in, can you add a touch more about the source of the data in the docs, just so its clear "it gets x via y mechanism" |
I added some notes and example output to the README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I tested it on my puppet environment and it behaved as described:
`[root@**************** puppetlabs]# puppet plan run pe_status_check::infra_role_summary
Starting plan job ...
New Plan Job ID: 1
|
{
"primary": [
"{-My primary Server-}"
],
"replica": [],
"compiler": [],
"postgres": [],
"legacy_primary": [],
"legacy_compiler": []
}`
This plan returns a hash of data with all PE infra nodes and their role.
I rebased this after #224 got merged. |
This plan returns a hash of data with all PE infra nodes and their role.
Please check off the steps below as you complete each step
(SUP-XXXX) Add Super Duper State Check
Ready for Review
if there is one